WA-NEW-009: Replace deprecated update_attributes in production code#633
Open
kitcommerce wants to merge 1 commit intonextfrom
Open
WA-NEW-009: Replace deprecated update_attributes in production code#633kitcommerce wants to merge 1 commit intonextfrom
kitcommerce wants to merge 1 commit intonextfrom
Conversation
kitcommerce
added
gate:build-pending
Author
Dispatcher Build Gate Summary (local)
Note: test output still prints BSON Symbol deprecation warning (expected to be addressed by WA-NEW-010 / PR #635). |
kitcommerce
added
review:architecture-pending
Author
|
No action needed from the PR author; I’ll retry dispatch once limits clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all deprecated
update_attributes/update_attributes!calls withupdate/update!across core production code (core/app/**,core/lib/**). This is required for Rails 7 whereupdate_attributesis removed.Also includes the WA-NEW-008 password reset fix (error-copying updated for Rails 7 compatibility).
Closes #626
Client impact
None expected.
update/update!are drop-in replacements with identical behavior. No public API changes.Verify
Files changed
17 files across core models, services, workers, seeds, and lib.